Checkstyle Results

The following document contains the results of Checkstyle.

Summary

FilesInfosWarningsErrors
81001810

Files

FilesIWE
org/neuclear/ledger/Book.java 0063
org/neuclear/ledger/ExceededHeldAmountException.java 006
org/neuclear/ledger/HeldTransaction.java 005
org/neuclear/ledger/InsufficientFundsException.java 0017
org/neuclear/ledger/InvalidTransactionException.java 006
org/neuclear/ledger/Ledger.java 0070
org/neuclear/ledger/LedgerController.java 00296
org/neuclear/ledger/LedgerCreationException.java 005
org/neuclear/ledger/LedgerException.java 0013
org/neuclear/ledger/LowlevelLedgerException.java 008
org/neuclear/ledger/PostedHeldTransaction.java 0021
org/neuclear/ledger/PostedTransaction.java 0038
org/neuclear/ledger/Transaction.java 0033
org/neuclear/ledger/TransactionExistsException.java 004
org/neuclear/ledger/TransactionExpiredException.java 009
org/neuclear/ledger/TransactionItem.java 0016
org/neuclear/ledger/UnBalancedTransactionException.java 007
org/neuclear/ledger/UnPostedHeldTransaction.java 0021
org/neuclear/ledger/UnPostedTransaction.java 0040
org/neuclear/ledger/UnknownBookException.java 009
org/neuclear/ledger/UnknownLedgerException.java 004
org/neuclear/ledger/UnknownTransactionException.java 009
org/neuclear/ledger/browser/BookBrowser.java 0060
org/neuclear/ledger/browser/BookListBrowser.java 0025
org/neuclear/ledger/browser/Browser.java 005
org/neuclear/ledger/browser/LedgerBrowser.java 0036
org/neuclear/ledger/browser/LedgerConfiguration.java 0011
org/neuclear/ledger/browser/PortfolioBrowser.java 0025
org/neuclear/ledger/browser/package.html 001
org/neuclear/ledger/package.html 001
org/neuclear/ledger/servlets/LedgerBrowserServlet.java 0059
org/neuclear/ledger/servlets/LedgerStatementServlet.java 0017
org/neuclear/ledger/servlets/PortfolioBrowserServlet.java 0037
org/neuclear/ledger/servlets/ServletLedgerFactory.java 0038
org/neuclear/ledger/servlets/package.html 001
org/neuclear/ledger/simple/LedgerData.java 002
org/neuclear/ledger/simple/PopulatedSimpleLedger.java 0013
org/neuclear/ledger/simple/SimpleBook.java 0041
org/neuclear/ledger/simple/SimpleLedgerController.java 00374
org/neuclear/ledger/simple/package.html 001
org/neuclear/ledger/tests/AbstractLedgerBrowserTest.java 00144
org/neuclear/ledger/tests/AbstractLedgerTest.java 00218
org/neuclear/ledger/tests/package.html 001

org/neuclear/ledger/Book.java

ErrorLine
Error Missing a header - not enough lines in file. 1
Error First sentence should end with a period. 26
Error Missing a Javadoc comment. 32
Error Line is longer than 80 characters. 35
Error Missing a Javadoc comment. 35
Error Parameter id should be final. 35
Error 'id' hides a field. 35
Error Parameter nickname should be final. 35
Error 'nickname' hides a field. 35
Error Parameter type should be final. 35
Error 'type' hides a field. 35
Error Parameter source should be final. 35
Error 'source' hides a field. 35
Error Parameter registered should be final. 35
Error 'registered' hides a field. 35
Error Parameter updated should be final. 35
Error 'updated' hides a field. 35
Error Parameter registrationid should be final. 35
Error 'registrationid' hides a field. 35
Error Missing a Javadoc comment. 45
Error Parameter id should be final. 45
Error 'id' hides a field. 45
Error Parameter registered should be final. 45
Error 'registered' hides a field. 45
Error '32' is a magic number. 48
Error Avoid inline conditionals. 48
Error '4' is a magic number. 49
Error '4' is a magic number. 50
Error '8' is a magic number. 50
Error Method 'getId' is not designed for extension - needs to be abstract, final or empty. 59
Error Missing a Javadoc comment. 59
Error Method 'getNickname' is not designed for extension - needs to be abstract, final or empty. 63
Error Missing a Javadoc comment. 63
Error Method 'getType' is not designed for extension - needs to be abstract, final or empty. 67
Error Missing a Javadoc comment. 67
Error Method 'getSource' is not designed for extension - needs to be abstract, final or empty. 71
Error Missing a Javadoc comment. 71
Error Method 'getRegistered' is not designed for extension - needs to be abstract, final or empty. 75
Error Missing a Javadoc comment. 75
Error Method 'getUpdated' is not designed for extension - needs to be abstract, final or empty. 79
Error Missing a Javadoc comment. 79
Error Method 'getRegistrationId' is not designed for extension - needs to be abstract, final or empty. 83
Error Missing a Javadoc comment. 83
Error Method 'equals' is not designed for extension - needs to be abstract, final or empty. 87
Error Missing a Javadoc comment. 87
Error Parameter o should be final. 87
Error Line is longer than 80 characters. 88
Error Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. 91
Error Missing a Javadoc comment. 91
Error Missing a Javadoc comment. 95
Error Variable 'id' must be private and have accessor methods. 95
Error Missing a Javadoc comment. 96
Error Variable 'nickname' must be private and have accessor methods. 96
Error Missing a Javadoc comment. 97
Error Variable 'type' must be private and have accessor methods. 97
Error Missing a Javadoc comment. 98
Error Variable 'source' must be private and have accessor methods. 98
Error Missing a Javadoc comment. 99
Error Variable 'registered' must be private and have accessor methods. 99
Error Missing a Javadoc comment. 100
Error Variable 'updated' must be private and have accessor methods. 100
Error Missing a Javadoc comment. 101
Error Variable 'registrationid' must be private and have accessor methods. 101

org/neuclear/ledger/ExceededHeldAmountException.java

ErrorLine
Error Missing a header - not enough lines in file. 1
Error Line is longer than 80 characters. 26
Error First sentence should end with a period. 30
Error Line is longer than 80 characters. 36
Error Missing a Javadoc comment. 36
Error Line is longer than 80 characters. 37

org/neuclear/ledger/HeldTransaction.java

ErrorLine
Error Missing a header - not enough lines in file. 1
Error First sentence should end with a period. 5
Error Line has trailing spaces. 6
Error Missing a Javadoc comment. 12
Error Redundant 'public' modifier. 12

org/neuclear/ledger/InsufficientFundsException.java

ErrorLine
Error Missing a header - not enough lines in file. 1
Error Line is longer than 80 characters. 11
Error Missing a Javadoc comment. 11
Error 'book' hides a field. 11
Error 'amount' hides a field. 11
Error Line is longer than 80 characters. 12
Error Line is longer than 80 characters. 17
Error Missing a Javadoc comment. 17
Error 'book' hides a field. 17
Error 'amount' hides a field. 17
Error Line is longer than 80 characters. 18
Error Method 'getAmount' is not designed for extension - needs to be abstract, final or empty. 23
Error Missing a Javadoc comment. 23
Error Method 'getBook' is not designed for extension - needs to be abstract, final or empty. 27
Error Missing a Javadoc comment. 27
Error Missing a Javadoc comment. 31
Error Missing a Javadoc comment. 32

org/neuclear/ledger/InvalidTransactionException.java

ErrorLine
Error Missing a header - not enough lines in file. 1
Error Line is longer than 80 characters. 11
Error Missing a Javadoc comment. 11
Error 'message' hides a field. 11
Error Missing a Javadoc comment. 16
Error Missing a Javadoc comment. 20

org/neuclear/ledger/Ledger.java

ErrorLine
Error Missing a header - not enough lines in file. 1
Error First sentence should end with a period. 26
Error Missing a Javadoc comment. 32
Error Line is longer than 80 characters. 35
Error Missing a Javadoc comment. 35
Error More than 7 parameters. 35
Error Parameter id should be final. 35
Error 'id' hides a field. 35
Error Parameter nickname should be final. 35
Error 'nickname' hides a field. 35
Error Parameter type should be final. 35
Error 'type' hides a field. 35
Error Parameter source should be final. 35
Error 'source' hides a field. 35
Error Parameter registered should be final. 35
Error 'registered' hides a field. 35
Error Parameter updated should be final. 35
Error 'updated' hides a field. 35
Error Parameter registrationid should be final. 35
Error 'registrationid' hides a field. 35
Error Parameter unit should be final. 35
Error 'unit' hides a field. 35
Error Parameter decimal should be final. 35
Error 'decimal' hides a field. 35
Error Missing a Javadoc comment. 47
Error Parameter id should be final. 47
Error 'id' hides a field. 47
Error Parameter registered should be final. 47
Error 'registered' hides a field. 47
Error '32' is a magic number. 50
Error Avoid inline conditionals. 50
Error '4' is a magic number. 51
Error '4' is a magic number. 52
Error '8' is a magic number. 52
Error Method 'getId' is not designed for extension - needs to be abstract, final or empty. 63
Error Missing a Javadoc comment. 63
Error Method 'getNickname' is not designed for extension - needs to be abstract, final or empty. 67
Error Missing a Javadoc comment. 67
Error Method 'getType' is not designed for extension - needs to be abstract, final or empty. 71
Error Missing a Javadoc comment. 71
Error Method 'getSource' is not designed for extension - needs to be abstract, final or empty. 75
Error Missing a Javadoc comment. 75
Error Method 'getRegistered' is not designed for extension - needs to be abstract, final or empty. 79
Error Missing a Javadoc comment. 79
Error Method 'getUpdated' is not designed for extension - needs to be abstract, final or empty. 83
Error Missing a Javadoc comment. 83
Error Method 'getRegistrationId' is not designed for extension - needs to be abstract, final or empty. 87
Error Missing a Javadoc comment. 87
Error Method 'getUnit' is not designed for extension - needs to be abstract, final or empty. 91
Error Missing a Javadoc comment. 91
Error Method 'getDecimalPoint' is not designed for extension - needs to be abstract, final or empty. 95
Error Missing a Javadoc comment. 95
Error Missing a Javadoc comment. 99
Error Variable 'id' must be private and have accessor methods. 99
Error Missing a Javadoc comment. 100
Error Variable 'nickname' must be private and have accessor methods. 100
Error Missing a Javadoc comment. 101
Error Variable 'type' must be private and have accessor methods. 101
Error Missing a Javadoc comment. 102
Error Variable 'source' must be private and have accessor methods. 102
Error Missing a Javadoc comment. 103
Error Variable 'registered' must be private and have accessor methods. 103
Error Missing a Javadoc comment. 104
Error Variable 'updated' must be private and have accessor methods. 104
Error Missing a Javadoc comment. 105
Error Variable 'registrationid' must be private and have accessor methods. 105
Error Missing a Javadoc comment. 106
Error Variable 'unit' must be private and have accessor methods. 106
Error Missing a Javadoc comment. 107
Error Variable 'decimal' must be private and have accessor methods. 107

org/neuclear/ledger/LedgerController.java

ErrorLine
Error Missing a header - not enough lines in file. 1
Error Line is longer than 80 characters. 7
Error Line is longer than 80 characters. 8
Error Line is longer than 80 characters. 11
Error Line is longer than 80 characters. 14
Error Line is longer than 80 characters. 17
Error Line is longer than 80 characters. 18
Error Line is longer than 80 characters. 31
Error Line is longer than 80 characters. 34
Error Line is longer than 80 characters. 42
Error Line is longer than 80 characters. 45
Error Line is longer than 80 characters. 56
Error Line is longer than 80 characters. 59
Error Line is longer than 80 characters. 60
Error Line is longer than 80 characters. 61
Error Line is longer than 80 characters. 78
Error Line is longer than 80 characters. 81
Error Line is longer than 80 characters. 82
Error Line is longer than 80 characters. 90
Error Line is longer than 80 characters. 95
Error Line is longer than 80 characters. 96
Error Line is longer than 80 characters. 100
Error Line is longer than 80 characters. 101
Error Line is longer than 80 characters. 102
Error Line is longer than 80 characters. 103
Error Line is longer than 80 characters. 107
Error Line is longer than 80 characters. 112
Error Line is longer than 80 characters. 113
Error Line is longer than 80 characters. 114
Error Line is longer than 80 characters. 127
Error Line is longer than 80 characters. 156
Error Line is longer than 80 characters. 163
Error Line is longer than 80 characters. 164
Error Line is longer than 80 characters. 168
Error Line is longer than 80 characters. 169
Error Line is longer than 80 characters. 174
Error Line is longer than 80 characters. 176
Error Line is longer than 80 characters. 188
Error First sentence should end with a period. 192
Error 'id' hides a field. 197
Error Expected @param tag for 'id'. 197
Error Missing a Javadoc comment. 201
Error 'id' hides a field. 201
Error Line is longer than 80 characters. 205
Error Line is longer than 80 characters. 210
Error Parameter trans should be final. 210
Error Expected @throws tag for 'UnBalancedTransactionException'. 210
Error Redundant throws: 'UnBalancedTransactionException' is subclass of 'InvalidTransactionException'. 210
Error Expected @throws tag for 'LowlevelLedgerException'. 210
Error Expected @throws tag for 'InvalidTransactionException'. 210
Error Line is longer than 80 characters. 213
Error Line is longer than 80 characters. 218
Error Parameter trans should be final. 218
Error Expected @throws tag for 'UnBalancedTransactionException'. 218
Error Redundant throws: 'UnBalancedTransactionException' is subclass of 'InvalidTransactionException'. 218
Error Expected @throws tag for 'LowlevelLedgerException'. 218
Error Expected @throws tag for 'InvalidTransactionException'. 218
Error Line is longer than 80 characters. 222
Error Line is longer than 80 characters. 223
Error Expected an @return tag. 227
Error Line is longer than 80 characters. 227
Error Parameter trans should be final. 227
Error Expected @throws tag for 'UnBalancedTransactionException'. 227
Error Redundant throws: 'UnBalancedTransactionException' is subclass of 'InvalidTransactionException'. 227
Error Expected @throws tag for 'LowlevelLedgerException'. 227
Error Expected @throws tag for 'InvalidTransactionException'. 227
Error Expected an @return tag. 238
Error Line is longer than 80 characters. 238
Error Parameter hold should be final. 238
Error Expected @param tag for 'hold'. 238
Error Expected @throws tag for 'LowlevelLedgerException'. 238
Error Expected @throws tag for 'UnknownTransactionException'. 238
Error Line is longer than 80 characters. 242
Error Line is longer than 80 characters. 245
Error Expected an @return tag. 252
Error Line is longer than 80 characters. 252
Error Parameter hold should be final. 252
Error Parameter amount should be final. 252
Error Parameter comment should be final. 252
Error Expected @param tag for 'comment'. 252
Error Expected @throws tag for 'InvalidTransactionException'. 252
Error Expected @throws tag for 'LowlevelLedgerException'. 252
Error Expected @throws tag for 'TransactionExpiredException'. 252
Error Expected @throws tag for 'UnknownTransactionException'. 252
Error Line is longer than 80 characters. 256
Error Line is longer than 80 characters. 261
Error Expected an @return tag. 268
Error Line is longer than 80 characters. 268
Error Parameter hold should be final. 268
Error Parameter origbook should be final. 268
Error Parameter newbook should be final. 268
Error Parameter amount should be final. 268
Error Parameter comment should be final. 268
Error Expected @param tag for 'comment'. 268
Error Expected @throws tag for 'InvalidTransactionException'. 268
Error Expected @throws tag for 'LowlevelLedgerException'. 268
Error Expected @throws tag for 'TransactionExpiredException'. 268
Error Expected @throws tag for 'UnknownTransactionException'. 268
Error First sentence should end with a period. 270
Error Line is longer than 80 characters. 276
Error Parameter id should be final. 276
Error 'id' hides a field. 276
Error Expected @throws tag for 'LowlevelLedgerException'. 276
Error Expected @throws tag for 'UnknownTransactionException'. 276
Error Line is longer than 80 characters. 279
Error Line is longer than 80 characters. 286
Error Line is longer than 80 characters. 291
Error Line is longer than 80 characters. 299
Error Parameter ledger should be final. 299
Error Expected @param tag for 'ledger'. 299
Error Parameter book should be final. 299
Error Expected @param tag for 'book'. 299
Error Expected @throws tag for 'LowlevelLedgerException'. 299
Error Method 'getBalance' is not designed for extension - needs to be abstract, final or empty. 301
Error Missing a Javadoc comment. 301
Error Parameter book should be final. 301
Error Line is longer than 80 characters. 307
Error Line is longer than 80 characters. 313
Error Line is longer than 80 characters. 318
Error Line is longer than 80 characters. 326
Error Parameter ledger should be final. 326
Error Expected @param tag for 'ledger'. 326
Error Parameter book should be final. 326
Error Expected @param tag for 'book'. 326
Error Expected @throws tag for 'LowlevelLedgerException'. 326
Error Line is longer than 80 characters. 328
Error Method 'getAvailableBalance' is not designed for extension - needs to be abstract, final or empty. 328
Error Missing a Javadoc comment. 328
Error Parameter book should be final. 328
Error Line is longer than 80 characters. 332
Error Missing a Javadoc comment. 332
Error Parameter ledger should be final. 332
Error Method 'getBookCount' is not designed for extension - needs to be abstract, final or empty. 334
Error Missing a Javadoc comment. 334
Error Line is longer than 80 characters. 340
Error Missing a Javadoc comment. 340
Error Parameter ledger should be final. 340
Error Method 'getTransactionCount' is not designed for extension - needs to be abstract, final or empty. 342
Error Missing a Javadoc comment. 342
Error Line is longer than 80 characters. 346
Error Missing a Javadoc comment. 346
Error Parameter id should be final. 346
Error 'id' hides a field. 346
Error Line is longer than 80 characters. 348
Error Missing a Javadoc comment. 348
Error Parameter id should be final. 348
Error 'id' hides a field. 348
Error First sentence should end with a period. 350
Error Expected an @return tag. 361
Error Line is longer than 80 characters. 361
Error Parameter id should be final. 361
Error 'id' hides a field. 361
Error Expected @param tag for 'id'. 361
Error Parameter nickname should be final. 361
Error Expected @param tag for 'nickname'. 361
Error Parameter type should be final. 361
Error Expected @param tag for 'type'. 361
Error Parameter source should be final. 361
Error Expected @param tag for 'source'. 361
Error Parameter registrationid should be final. 361
Error Expected @param tag for 'registrationid'. 361
Error Expected @throws tag for 'LowlevelLedgerException'. 361
Error Line is longer than 80 characters. 363
Error Missing a Javadoc comment. 363
Error Parameter id should be final. 363
Error